Skip to content

FF139 Relnote - Escape < and > in attributes when serializing HTML #39364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

FF139 Relnote - Escape < and > in attributes when serializing HTML #39364

merged 2 commits into from
May 5, 2025
+4 −0

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 2, 2025 •
edited
Loading

FF139 escapes < as &lt; and > as &gt; in attribute values when HTML is serialized (i.e. when reading Element.innerHTML, Element.outerHTML, Element.getHTML(), ShadowRoot.innerHTML, , ShadowRoot.getHTML().

This is the release note update.

Related docs can be tracked in #39309

@hamishwillee hamishwillee requested a review from a team as a code owner May 2, 2025 04:34
@hamishwillee hamishwillee requested review from dipikabh and removed request for a team May 2, 2025 04:34
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels May 2, 2025
@hamishwillee hamishwillee changed the base branch from main to firefox/139 May 2, 2025 04:34
@hamishwillee hamishwillee mentioned this pull request May 2, 2025
Open
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025

Preview URLs

External URLs (4)

URL: /en-US/docs/Mozilla/Firefox/Releases/139
Title: Firefox 139 for developers

dipikabh
dipikabh approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!
Just some minor edit suggestions

@dipikabh dipikabh mentioned this pull request May 2, 2025
Merged
@hamishwillee @dipikabh
Apply suggestions from code review
bb89fff 
Co-authored-by: Dipika Bhattacharya <[email protected]>
@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed size/m [PR only] 51-500 LoC changed labels May 5, 2025
@hamishwillee
Copy link
Collaborator Author

Thanks very much. So good to get early review.

@hamishwillee hamishwillee merged commit f4651c1 into mdn:firefox/139 May 5, 2025
4 checks passed
@hamishwillee hamishwillee deleted the ff139_relnote2_escape_attr_html branch May 5, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

Assignees
No one assigned
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @dipikabh